feat: enable optional UDF arguments in regexp_* functions
#10512
Labels
enhancement
New feature or request
Comments
|
take. will have a PR up shortly |
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion
that referenced
this issue
May 15, 2024
This also updates the argument names to match what is used in the inner impl. Ref apache#10512
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion
that referenced
this issue
May 15, 2024
This also updates the argument names to match the inner impl. Ref apache#10512
Michael-J-Ward
added a commit
to Michael-J-Ward/datafusion
that referenced
this issue
May 15, 2024
This also updates the argument names to match the inner impl. Ref apache#10512
jonahgao
pushed a commit
that referenced
this issue
May 15, 2024
* refactor: declare `regex::expr_fn`s explicitly instead of using the macro This does not change any functionality but enables adding optional arguments to each fn. * feat: make `flag` argument optional for expr_fn::regexp_replace This also updates the argument names to match what is used in the inner impl. Ref #10512 * feat: add optional `flags` argument to expr_fn::regexp_match This also updates the argument names to match the inner impl. Ref #10512 * feat: add optional `flags` argument to expr_fn::regexp_like This also updates the argument names to match the inner impl. Ref #10512 * docs: clean up doc comments for expr_fn::regexp_* * refactor: use datafusion_expr::Expr declaration
findepi
pushed a commit
to findepi/datafusion
that referenced
this issue
Jul 16, 2024
* refactor: declare `regex::expr_fn`s explicitly instead of using the macro This does not change any functionality but enables adding optional arguments to each fn. * feat: make `flag` argument optional for expr_fn::regexp_replace This also updates the argument names to match what is used in the inner impl. Ref apache#10512 * feat: add optional `flags` argument to expr_fn::regexp_match This also updates the argument names to match the inner impl. Ref apache#10512 * feat: add optional `flags` argument to expr_fn::regexp_like This also updates the argument names to match the inner impl. Ref apache#10512 * docs: clean up doc comments for expr_fn::regexp_* * refactor: use datafusion_expr::Expr declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem or challenge?
The same discussion / reasoning as in #10424.
The
innerimplementation for these UDFs changes based on the number of parameters passed, but the API of the exportedregex::expr_fn::*does not enable that.Describe the solution you'd like
The same solution as implemented #10469, change the exported
expr_fns to takeOption<Expr>for optional arguments.Describe alternatives you've considered
Alternatives discussed in the prior issue:
Vecinstead of explicit argumentsexpr_fnfor each set of non-null parametersAdditional context
No response
The text was updated successfully, but these errors were encountered: