[fix #8904] Improved output of datafuson-cli with empty results

Signed-off-by: tangruilin <[email protected]>
apache · Jan 22, 2024 · fda1b81 · fda1b81
1 parent d81c961
commit fda1b81
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/datafusion/physical-plan/src/coalesce_batches.rs b/datafusion/physical-plan/src/coalesce_batches.rs
@@ -230,7 +230,8 @@ impl CoalesceBatchesStream {
                         {
                             return Poll::Ready(Some(Ok(batch)));
                         } else if batch.num_rows() == 0 {
-                            // discard empty batches
+                            // for empty batches, it also should be print
+                            return Poll::Ready(Some(Ok(batch)));
                         } else {
                             // add to the buffered batches
                             self.buffered_rows += batch.num_rows();

diff --git a/datafusion/physical-plan/src/filter.rs b/datafusion/physical-plan/src/filter.rs
@@ -312,10 +312,6 @@ impl Stream for FilterExecStream {
                     Some(Ok(batch)) => {
                         let timer = self.baseline_metrics.elapsed_compute().timer();
                         let filtered_batch = batch_filter(&batch, &self.predicate)?;
-                        // skip entirely filtered batches
-                        if filtered_batch.num_rows() == 0 {
-                            continue;
-                        }
                         timer.done();
                         poll = Poll::Ready(Some(Ok(filtered_batch)));
                         break;