Skip to content

Commit

Permalink
Fix verification scripts for 7.0.0 release (#1830)
Browse files Browse the repository at this point in the history
* Update release and verify scripts

* fixup

* Fix publish check

* remove python check
  • Loading branch information
alamb authored Feb 14, 2022
1 parent 79b46f8 commit ca765d5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 16 deletions.
7 changes: 0 additions & 7 deletions dev/release/create-tarball.sh
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,6 @@ gpg --armor --output ${tarball}.asc --detach-sig ${tarball}
(cd ${distdir} && shasum -a 256 ${tarname}) > ${tarball}.sha256
(cd ${distdir} && shasum -a 512 ${tarname}) > ${tarball}.sha512

# download python binary releases from Github Action
python_distdir=${distdir}/python
echo "Preparing python release artifacts"
test -d ${python_distdir} || mkdir -p ${python_distdir}
pushd "${python_distdir}"
python ${SOURCE_DIR}/download-python-wheels.py "${tag}"
popd

echo "Uploading to apache dist/dev to ${url}"
svn co --depth=empty https://dist.apache.org/repos/dist/dev/arrow ${SOURCE_TOP_DIR}/dev/dist
Expand Down
14 changes: 5 additions & 9 deletions dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fetch_archive() {

verify_dir_artifact_signatures() {
# verify the signature and the checksums of each artifact
find $1 -name '*.asc' | while read sigfile; do
find . -name '*.asc' | while read sigfile; do
artifact=${sigfile/.asc/}
gpg --verify $sigfile $artifact || exit 1

Expand Down Expand Up @@ -135,7 +135,10 @@ test_source_distribution() {
exit 1
fi

pushd datafusion

# Note can't verify datafusion or datafusion-expr as they depend
# on datafusion-common which isn't published yet
pushd datafusion-common
cargo publish --dry-run
popd
}
Expand All @@ -154,13 +157,6 @@ pushd ${dist_name}
test_source_distribution
popd

echo "Verifying python artifacts..."
svn co $ARROW_DIST_URL/apache-arrow-datafusion-${VERSION}-rc${RC_NUMBER}/python python-artifacts
pushd python-artifacts
verify_dir_artifact_signatures
twine check *.{whl,tar.gz}
popd

TEST_SUCCESS=yes
echo 'Release candidate looks good!'
exit 0

0 comments on commit ca765d5

Please sign in to comment.