Skip to content

Commit

Permalink
Implement missing join types for Python dataframe (#503)
Browse files Browse the repository at this point in the history
* Implement missing join types for Python dataframe

* Fix mapping

* Use commit hash instead

* undo some changes

* Remove imports

* Undo removed part

* Undo removed part

* minimize changes
  • Loading branch information
Dandandan authored Jun 4, 2021
1 parent c92079d commit a0370b2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion python/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ libc = "0.2"
tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread", "sync"] }
rand = "0.7"
pyo3 = { version = "0.13.2", features = ["extension-module"] }
datafusion = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c3fc0c75af5ff2ebb99dba197d9d2ccd83eb5952" }
datafusion = { git = "https://github.com/apache/arrow-datafusion.git", rev = "c92079dfb3045a9a46d12c3bc22361a44d11b8bc" }

[lib]
name = "datafusion"
Expand Down
3 changes: 3 additions & 0 deletions python/src/dataframe.rs
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ impl DataFrame {
"inner" => JoinType::Inner,
"left" => JoinType::Left,
"right" => JoinType::Right,
"full" => JoinType::Full,
"semi" => JoinType::Semi,
"anti" => JoinType::Anti,
how => {
return Err(DataFusionError::Common(format!(
"The join type {} does not exist or is not implemented",
Expand Down

0 comments on commit a0370b2

Please sign in to comment.