Merge s3_build_error and s3_success into one test (#3602)

apache · Sep 24, 2022 · 8bcc965 · 8bcc965
1 parent 0b204c6
commit 8bcc965
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/datafusion-cli/src/object_storage.rs b/datafusion-cli/src/object_storage.rs
@@ -130,20 +130,15 @@ mod tests {
     }
 
     #[test]
-    fn s3_build_error() {
+    fn s3_region_validation() {
         let s3 = "s3://bucket_name/path";
         let provider = DatafusionCliObjectStoreProvider {};
         let err = provider
             .get_by_url(&Url::from_str(s3).unwrap())
             .unwrap_err();
         assert!(err.to_string().contains("Generic S3 error: Missing region"));
-    }
 
-    #[test]
-    fn s3_success() {
-        let s3 = "s3://bucket_name/path";
         env::set_var("AWS_DEFAULT_REGION", "us-east-1");
-        let provider = DatafusionCliObjectStoreProvider {};
         assert!(provider.get_by_url(&Url::from_str(s3).unwrap()).is_ok());
         env::remove_var("AWS_DEFAULT_REGION");
     }