Skip to content

Commit

Permalink
fix clippy
Browse files Browse the repository at this point in the history
  • Loading branch information
peter-toth committed Jan 10, 2024
1 parent e852485 commit 6237e2a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion datafusion/physical-expr/src/intervals/cp_solver.rs
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ impl ExprIntervalGraphNode {
&self.interval
}

/// This function creates a DAEG node from Datafusion's [`ExprTreeNode`]
/// This function creates a DAEG node from Datafusion's [`PhysicalExpr`]
/// object. Literals are created with definite, singleton intervals while
/// any other expression starts with an indefinite interval ([-∞, ∞]).
pub fn make_node(expr: &Arc<dyn PhysicalExpr>, schema: &Schema) -> Result<Self> {
Expand Down
5 changes: 2 additions & 3 deletions datafusion/physical-expr/src/utils/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,8 @@ pub fn get_indices_of_exprs_strict<T: Borrow<Arc<dyn PhysicalExpr>>>(
.collect()
}

/// This struct facilitates the [TreeNodeRewriter] mechanism to convert a
/// [PhysicalExpr] tree into a DAEG (i.e. an expression DAG) by collecting
/// identical expressions in one node. Caller specifies the node type in the
/// This struct converts a [PhysicalExpr] tree into a DAEG (i.e. an expression DAG) by
/// collecting identical expressions in one node. Caller specifies the node type in the
/// DAEG via the `constructor` argument.
struct PhysicalExprDAEGBuilder<'a, T, F: Fn(&Arc<dyn PhysicalExpr>) -> Result<T>> {
// The resulting DAEG (expression DAG).
Expand Down

0 comments on commit 6237e2a

Please sign in to comment.