Fix Stack overflow in sql planning in debug builds (#4779)

* fix: stackoverflow in planning tpcds queries * uncomment some other tests * fix: fmt * Apply suggestions from code review * Update datafusion/core/tests/tpcds_planning.rs
apache · Jan 1, 2023 · 0d6d371 · 0d6d371
1 parent 9a8190a
commit 0d6d371
Show file tree

Hide file tree

Showing 2 changed files with 406 additions and 314 deletions.
diff --git a/datafusion/core/tests/tpcds_planning.rs b/datafusion/core/tests/tpcds_planning.rs
@@ -43,7 +43,6 @@ async fn tpcds_logical_q3() -> Result<()> {
     create_logical_plan(3).await
 }
 
-#[ignore] // thread 'q4' has overflowed its stack
 #[tokio::test]
 async fn tpcds_logical_q4() -> Result<()> {
     create_logical_plan(4).await
@@ -179,7 +178,6 @@ async fn tpcds_logical_q30() -> Result<()> {
     create_logical_plan(30).await
 }
 
-#[ignore] // thread 'q31' has overflowed its stack
 #[tokio::test]
 async fn tpcds_logical_q31() -> Result<()> {
     create_logical_plan(31).await
@@ -345,7 +343,7 @@ async fn tpcds_logical_q63() -> Result<()> {
     create_logical_plan(63).await
 }
 
-#[ignore] // thread 'q64' has overflowed its stack
+#[ignore] // thread 'q64' has overflowed its stack]
 #[tokio::test]
 async fn tpcds_logical_q64() -> Result<()> {
     create_logical_plan(64).await
@@ -541,7 +539,6 @@ async fn tpcds_physical_q3() -> Result<()> {
     create_physical_plan(3).await
 }
 
-#[ignore] // thread 'q4' has overflowed its stack
 #[tokio::test]
 async fn tpcds_physical_q4() -> Result<()> {
     create_physical_plan(4).await
@@ -683,7 +680,6 @@ async fn tpcds_physical_q30() -> Result<()> {
     create_physical_plan(30).await
 }
 
-#[ignore] // thread 'q31' has overflowed its stack
 #[tokio::test]
 async fn tpcds_physical_q31() -> Result<()> {
     create_physical_plan(31).await