Support snowflake double dot notation for object name #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayman-sigma
commented
Nov 20, 2024
src/parser/mod.rs
Outdated
| @@ -8349,6 +8349,13 @@ impl<'a> Parser<'a> { | |||
| pub fn parse_object_name(&mut self, in_table_clause: bool) -> Result<ObjectName, ParserError> { | |||
| let mut idents = vec![]; | |||
| loop { | |||
| if self.dialect.supports_object_name_double_dot_notation() | |||
| && !idents.is_empty() | |||
There was a problem hiding this comment.
I'm debating if I should force it only for missing schema. Which means only accepts x..y and rejects stuff like x.y..z. Forcing this seems like a semantic validation that we are trying to avoid.
There was a problem hiding this comment.
There was a test case that specifically test the invalid object name of x.y..z. So I updated it to support only missing schema in x..y.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowflake allows double-dot notation in the object name. The two dots indicate that the schema name is not specified. The PUBLIC default schema is always referenced. See more details here: https://docs.snowflake.com/en/sql-reference/name-resolution#resolution-when-schema-omitted-double-dot-notation
Right now I'm parsing the default schema segment as an empty identifier. Depending on the acceptance of this PR, we can change this to be something like
DefaultSchemainstead.