PartiQL queries in Redshift #1534
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
reviewed
Nov 20, 2024
tests/sqlparser_redshift.rs
Outdated
| #[test] | ||
| fn test_redshift_json_path() { | ||
| let sql = "SELECT cust.c_orders[0].o_orderkey FROM customer_orders_lineitem"; | ||
| let select = redshift().verified_only_select(sql); |
There was a problem hiding this comment.
Could we use let dialect = all_dialects_where(|d| d.supports_partiql()) for the tests? thinking so any dialect that gets this feature can potentially reuse the same tests
src/ast/query.rs
Outdated
Comment on lines
977
to
978
| /// Optional PartiQL JsonPath: <https://partiql.org/dql/from.html> | ||
| partiql: Option<JsonPath>, |
There was a problem hiding this comment.
Maybe we can call this json_path to be generic (in the doc we mention partiql as one example)?
tests/sqlparser_redshift.rs
Outdated
|
|
||
| #[test] | ||
| fn test_parse_json_path_from() { | ||
| let select = redshift().verified_only_select("SELECT * FROM src[0].a AS a"); |
There was a problem hiding this comment.
Could we add a test for something containing a qualified name e.g. a.b.c[0].d (it wasn't clear from the code how that's represented or rejected if its not valid partiql)?
iffyio
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for parsing PartiQL queries in Redshift