-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse true and false as identifiers in mssql #1510
Conversation
There are 7 failing tests at the moment. From a quick glance, it looks like it's the tests that are incorrect: they rely on the existence of boolean literals in all dialects. |
…g a false literal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
Ci appears to be failing on this PR |
@alamb : Sorry ! It's fixed now. |
🤔 I don't know why but this repo now seems to require manually starting CI. I will look into it |
@alamb It's the Apache organization's setting behavior if my memory serves. All repositories in the organization are required to manually trigger CI for non-members. |
I have filed https://issues.apache.org/jira/browse/INFRA-26268 for trying to ensure CI runs automatically |
Thanks @git-hulk -- arrow and DataFusion both are set to run CI after the first time a contributor has had a PR merged. I filed https://issues.apache.org/jira/browse/INFRA-26268 to request the same setting on this repository (what it used to be as well) |
fixes #1508