Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse true and false as identifiers in mssql #1510

Merged
merged 9 commits into from
Nov 13, 2024

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Nov 10, 2024

fixes #1508

@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 10, 2024

There are 7 failing tests at the moment. From a quick glance, it looks like it's the tests that are incorrect: they rely on the existence of boolean literals in all dialects.

@lovasoa lovasoa marked this pull request as ready for review November 10, 2024 11:17
@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 10, 2024

Ok, I fixed all the tests, this is ready for review @iffyio, @alamb :)

@lovasoa lovasoa changed the title WIP: parse true and false as identifiers in mssql Parse true and false as identifiers in mssql Nov 10, 2024
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@alamb
Copy link
Contributor

alamb commented Nov 12, 2024

Ci appears to be failing on this PR

@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 13, 2024

@alamb : Sorry ! It's fixed now.

@alamb
Copy link
Contributor

alamb commented Nov 13, 2024

🤔 I don't know why but this repo now seems to require manually starting CI. I will look into it

@alamb alamb merged commit 3a8369a into apache:main Nov 13, 2024
8 checks passed
@git-hulk
Copy link
Member

git-hulk commented Nov 13, 2024

@alamb It's the Apache organization's setting behavior if my memory serves. All repositories in the organization are required to manually trigger CI for non-members.

@alamb
Copy link
Contributor

alamb commented Nov 13, 2024

I have filed https://issues.apache.org/jira/browse/INFRA-26268 for trying to ensure CI runs automatically

@alamb
Copy link
Contributor

alamb commented Nov 13, 2024

@alamb It's the Apache organization's setting behavior if my memory serves. All repositories in the organization are required to manually trigger CI for non-members.

Thanks @git-hulk -- arrow and DataFusion both are set to run CI after the first time a contributor has had a PR merged. I filed https://issues.apache.org/jira/browse/INFRA-26268 to request the same setting on this repository (what it used to be as well)

@lovasoa lovasoa deleted the mssql_no_boolean_literal branch November 13, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parse true and false as column names, not booleans in Microsoft SQL server
4 participants