-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for MSSQL's XQuery
methods
#1500
Conversation
I redesigned |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look and left some highlevel comment, will make time soon to take a closer look. Thanks for clarifying the behavior @gaoqiangz together with the rework the intention is much clearer to me!
I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaoqiangz took a look now and left some comments
The code has been rewritten for the new pub struct Method {
pub expr: Box<Expr>,
// always non-empty
pub method_chain: Vec<Function>,
} Any other comments? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! cc @alamb
@gaoqiangz could you take a look at the doc building failure when you get the chance? |
@iffyio CI was fixed. |
🚀 |
Thanks again @gaoqiangz and @lovasoa and @iffyio |
@gaoqiangz I've been working on a similar addition, it's great to see you beat me to it :-) One thing I added in my (unpublished) work is data-type specific methods. For example: How would you support the |
Supports
XQuery
methods:See https://learn.microsoft.com/en-us/sql/t-sql/xml/xml-data-type-methods?view=sql-server-ver16.