Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrain JSON_TABLE table function parsing to MySqlDialect and AnsiDialect #1123
Restrain JSON_TABLE table function parsing to MySqlDialect and AnsiDialect #1123
Changes from 10 commits
d7727a1
5f73e1a
be776e5
bed4af3
d7fdae5
6febd52
df1398b
0b225bf
e1e5c41
b7a4d3b
80a3dda
7f7d764
b27da0f
545c661
96ecfb1
8ce05b3
cd10ba5
7b803a3
ff4c995
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I think it would be possible to call
peek_nth_token
here as well to avoid having to reset index. However, this works fine toohttps://docs.rs/sqlparser/latest/sqlparser/parser/struct.Parser.html#method.peek_nth_token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good suggestion. Changed to use
peek_nth_token
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And, even for the supported dialects,
json_table
cannot be used as table identifier too. Previously it cannot be too but the paring error looks confusing.