Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigQuery: Parse optional DELETE FROM statement #1120

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

iffyio
Copy link
Contributor

@iffyio iffyio commented Jan 31, 2024

The FROM keyword is optional is a DELETE statement for BigQuery This adds parser support to handle such statements

@coveralls
Copy link

coveralls commented Jan 31, 2024

Pull Request Test Coverage Report for Build 7731356195

  • -4 of 61 (93.44%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.008%) to 87.666%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 14 15 93.33%
tests/sqlparser_bigquery.rs 14 17 82.35%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_common.rs 2 97.08%
Totals Coverage Status
Change from base Build 7660582105: 0.008%
Covered Lines: 19525
Relevant Lines: 22272

💛 - Coveralls

The `FROM` keyword is optional is a `DELETE` statement
for [BigQuery](https://cloud.google.com/bigquery/docs/reference/standard-sql/dml-syntax#delete_statement)
This adds parser support to handle such statements
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @iffyio

@alamb alamb merged commit df738f9 into apache:main Feb 4, 2024
10 checks passed
@iffyio
Copy link
Contributor Author

iffyio commented Feb 4, 2024

Thanks!

@iffyio iffyio deleted the bigquery-opt-delete-from branch February 4, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants