-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ENABLE and DISABLE on ALTER TABLE for pg #1077
Conversation
Signed-off-by: Toby Hede <[email protected]>
Pull Request Test Coverage Report for Build 7362770487
💛 - Coveralls |
0f43971
to
d663b19
Compare
Signed-off-by: Toby Hede <[email protected]>
d663b19
to
fc35013
Compare
chars, | ||
|ch| matches!(ch, '0'..='9' | 'A'..='F' | 'a'..='f'), | ||
); | ||
let s2 = peeking_take_while(chars, |ch| ch.is_ascii_hexdigit()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New clippy rule dropped.
@@ -1077,7 +1074,7 @@ impl<'a> Tokenizer<'a> { | |||
match chars.peek() { | |||
Some('$') => { | |||
chars.next(); | |||
for (_, c) in value.chars().enumerate() { | |||
for c in value.chars() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New clippy rule dropped.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thank you for the contribution @tobyhede
@@ -349,6 +349,7 @@ mod tests { | |||
} | |||
} | |||
|
|||
#[allow(clippy::needless_raw_string_hashes)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we can fix this in a follow on PR (as in remove the clippy allow and then fix the tests to conform to the new clippy opinions)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, is a good idea. I tried to fix, but without the raw the parser errors with Unterminated string literal
.
I wasn't sure enough of the underlying intent to make more a dramatic change.
Add support for the following pg syntax