Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for CALL statements #1063

Merged
merged 2 commits into from
Dec 19, 2023
Merged

add support for CALL statements #1063

merged 2 commits into from
Dec 19, 2023

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Dec 4, 2023

see https://dev.mysql.com/doc/refman/8.0/en/call.html

Adds support for MySQL's CALL statements
(stored procedure invocation)

This one is very important for SQLPage too,
because it allows working around other unsupported syntax
by wrapping logic in stored procedures.

see https://dev.mysql.com/doc/refman/8.0/en/call.html

Adds support for MySQL's CALL statements
(stored procedure invocation)

This one is very important for SQLPage too,
because it allows working around other unsupported syntax
by wrapping logic in stored procedures.
@coveralls
Copy link

coveralls commented Dec 4, 2023

Pull Request Test Coverage Report for Build 7112190425

  • 29 of 34 (85.29%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 87.702%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/mod.rs 13 18 72.22%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 79.05%
Totals Coverage Status
Change from base Build 7009122777: -0.004%
Covered Lines: 18021
Relevant Lines: 20548

💛 - Coveralls

src/ast/mod.rs Show resolved Hide resolved
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @lovasoa

@alamb alamb merged commit 1933f19 into apache:main Dec 19, 2023
10 checks passed
@lovasoa lovasoa deleted the call branch December 20, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants