CURATOR-624: Fix Github Actions by adding 'distribution' for JDK setup step #407
Conversation
Merge the two workflows into one and use strategy.matrix for the Java versions Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
|
@nicoloboschi do you mind taking a look here ? |
|
It seems with one additional minor change (upgrade Mockito-core to 4.3.1) and few import fixes the build will pass with JDK 17 too. |
Upgrade Mockito (for JDK 17) and JUnit 5 Signed-off-by: Martin Tzvetanov Grigorov <[email protected]>
|
I guess the test failures are expected. |
martin-g
changed the title
this would be great, thanks |
|
Maybe if you remove the jdk17 part and we see ci passing we can merge this pr and unblock the pipeline Does it sound like a good plan to you? |
|
We need #409 to be merged to see green build for JDK 1.8 and 11.
I'll comment out 17!
…On Fri, Feb 25, 2022, 18:31 Enrico Olivelli ***@***.***> wrote:
Maybe if you remove the jdk17 part and we see ci passing we can merge this
pr and unblock the pipeline
Does it sound like a good plan to you?
—
Reply to this email directly, view it on GitHub
<#407 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYUQTYSAPVRJRRZZKMZCLU46VGRANCNFSM5PJX3F3Q>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Let's remove jdk17 stuff and merge this pr |
|
Then we can commit your fix to the test and add back 17 |
This reverts commit 3e5ac14.
|
OK. The last commit is reverted! |
Merge the two workflows into one and use strategy.matrix for the Java
versions.