Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default config settings #2228

Merged
merged 2 commits into from
Oct 4, 2019
Merged

Update default config settings #2228

merged 2 commits into from
Oct 4, 2019

Conversation

rnewson
Copy link
Member

@rnewson rnewson commented Oct 3, 2019

Overview

Update default config settings

Testing recommendations

In a fresh install, create a database, confirm that it is q=2. Try to create a >8mb document and confirm that it fails.

Related Issues or Pull Requests

#2115

@wohali
Copy link
Member

wohali commented Oct 3, 2019

Still not happy with 2MB as the default document size but I can see that I'm going to be outvoted by the Cloudant contingent on this.

@rnewson rnewson force-pushed the update-couchdb-defaults branch from 0dc918c to cd425f9 Compare October 3, 2019 18:30
@rnewson
Copy link
Member Author

rnewson commented Oct 3, 2019

discussed in couchdb-dev on IRC, Wohali is not comfortable dropping all the way to 1MB. Given the upcoming FDB restriction on a txn to 10MB, we've compromised on a new default of 8MB (8 million bytes). This is still a vast improvement over the unattainable 4 GiB default of old.

Copy link
Member

@janl janl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we leave a note somewhere that we do not forget to review this prior to 3.0, I’m +1 on this.

q=2
max_document_size = 8000000 ; 8 MB.

#2115
@rnewson rnewson force-pushed the update-couchdb-defaults branch from cd425f9 to f4998fb Compare October 4, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants