Allow to use $or with a mango JSON index #1011
Closed
+27
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since apache#816, mango JSON index on compound fields can be selected only if the selector make sure that all the fields listed in the index are always present. This commit add a special case where all clauses of an `$or` can ensure that a field is present. For instance, if I had an index: [A, B] is_usable would now return true for the selector: { "A": "foo", "$or": { "B": "bar", "B": "baz" } }
|
Thanks for this @nono. Would you be able to write an integration test (e.g. https://github.com/apache/couchdb/blob/master/src/mango/test/05-index-selection-test.py#L24)? It's probably also looking at #1014 as that PR changes the implementation of |
|
fixed in #1038 |
|
Thanks @willholley! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Since #816, mango JSON index on compound fields can be selected only if the selector make sure that all the fields listed in the index are always present. This commit add a special case where all clauses of an
$orcan ensure that a field is present.For instance, if I had an index:
is_usable would now return true for the selector:
{ "A": "foo", "$or": { "B": "bar", "B": "baz" } }Testing recommendations
Run the mango test suite. Manually run some mango queries with/without JSON indexes and check that the results are as expected.
Related Issues or Pull Requests
Checklist