Deallocate future mutex in the future resource destructor #50
Conversation
Otherwise we end up leaking mutexes #49
|
Bah, we need to update CI for the foundationdb.org switch. |
kocolosk
force-pushed
the
deallocate-future-mutex-in-resource-destructor
branch
from
47d3331
to
61332f6
Compare
|
Seems like there's an issue with the 6.2.30 Windows install of FDB (the build is crashing when it tries to parse the output of |
|
Ah makes sense, @kocolosk, thanks for taking a look. I had noticed the user reported an abort and core dump #49 (comment) and wondering if we have another bug or I misunderstood how resource reference counting and destructors work. |
|
It looks like the user double-checked and the issue doesn't happen any longer (it was a build / compile issue) before. |
|
Great sleuthing here. Can you push a git tag for this please? I’ll update downstream FreeBSD when that’s done
…On Tue, 25 Jan 2022, at 21:48, Nick Vatamaniuc wrote:
Merged #50 <#50> into main.
—
Reply to this email directly, view it on GitHub
<#50 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACFNUGTUXYPHJV4Z4MFIBDUX4EBRANCNFSM5MY4WSLA>.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this
thread.Message ID:
***@***.***>
--
—
Dave Cottlehuber
***@***.***
Sent from my Couch
|
|
@dch good idea, will do |
|
tagged https://github.com/apache/couchdb-erlfdb/releases/tag/v1.3.5 gave the "autogenerate release notes" button a try. seems to work well enough |
Otherwise we end up leaking mutexes #49