Configure FDB_API_VERSION dynamically #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
reviewed
Nov 8, 2021
| VsnInfo = os:cmd("fdbcli --version"), | ||
| {match, [ProtocolStr]} = re:run(VsnInfo, "protocol ([a-f0-9]*)", [{capture, [1], list}]), | ||
| ProtocolVsn = list_to_integer(ProtocolStr, 16), | ||
| APIVersionBytes = (ProtocolVsn band 16#0000000FFF00000) bsr 20, |
There was a problem hiding this comment.
Hah, I thought it seemed quite hacky, but looking at the way it's defined in FDB I suspect this ends up being pretty reliable
nickva
approved these changes
Nov 8, 2021
|
While we are technically green on 6.3 here, it seems there are a handful of changes in API version 630 that we ought to be accounting for: https://apple.github.io/foundationdb/api-version-upgrade-guide.html#api-version-630 Specifically:
|
|
Will squash the CI commits into one to clean up the history, but this is stacked on top of #33 so I think I may wait until that one is merged to proceed further. |
kocolosk
force-pushed
the
configure-fdb-version
branch
from
3d879cb
to
26986b3
Compare
This is the new name for ENABLE_SLOW_TASK_PROFILING.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set dynamically detects the maximum API version supported by the installed FDB client library and builds the NIF wrapper against that version automatically.
Older API versions can still be selected at runtime as usual through the application environment; this just ensures we have the largest possible range at our disposal, without restricting the versions of the client library we can support with a single branch of this codebase.
Closes #34
Closes #38