Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova Plugman Release Preparation (Cordova 9) #108

Merged
merged 11 commits into from
Mar 20, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Mar 19, 2019

Platforms affected

none

Motivation and Context

Cordova 9 Release

Description

This PR contains final preparations for the Cordova 9 release goals.

See Cordova 9 Release Plan.

  • Added missing known options that causes the latest nopt to display Boolean values vs String values.

  • Changed version from boolean to string.

  • Updated test to use actual knownOptions and shortHands

  • Bumped Dependencies

    • cordova-lib@^9.0.0
    • nopt@^4.0.1
  • Bumped ESLint dependencies with correction

    • eslint@^5.15.3
    • eslint-config-semistandard@^13.0.0
    • eslint-config-standard@^12.0.0
    • eslint-plugin-import@^2.16.0
    • eslint-plugin-node@^8.0.1
    • eslint-plugin-promise@^4.0.1
    • eslint-plugin-standard@^4.0.0
  • Updated Dev Dependencies

    • jasmine@^3.3.1
    • rewire@^4.0.1

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu requested a review from raphinesse March 19, 2019 14:58
@erisu erisu requested review from dpogue and shazron March 19, 2019 14:58
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@erisu erisu merged commit 01cf5a3 into apache:master Mar 20, 2019
@erisu erisu deleted the cordova9-prep branch April 4, 2019 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants