Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(android)!: Remove unused code #183

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

jcesarmobile
Copy link
Member

There are unused variables, methods and fireos leftovers that are unused

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcesarmobile jcesarmobile changed the title refactor(android): Remove unused code refactor(android)!: Remove unused code Oct 18, 2022
@jcesarmobile
Copy link
Member Author

Changing the title to add ! (Breaking), since despite those methods are not called from the js side, users might be using the plugin as a dependency and calling those methods from native code (should be possible since they are public).

@jcesarmobile jcesarmobile merged commit deaae75 into master May 13, 2024
@jcesarmobile jcesarmobile deleted the android-cleanup branch May 13, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants