-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ios): detect if app is running on a macOS desktop with Apple Silicon #167
Conversation
Co-authored-by: エリス <[email protected]>
Rebased, and includes the suggestion from erisu
de74384
to
396e8c7
Compare
I noticed your PR had additional commits that were not related to your PR. I think there was an error with the rebase. I went ahead and created a new PR based on the latest main branch and cherry-picked your changes. I also pushed an extra commit to fix the failing GitHub Actions iOS tests. Your PR had the necessary My additional change here: 8938cf7 If you want to test run this PR that would be great. |
Ran the new code on Apple Silicon...
and it worked perfectly. And as expected on a iPhone simulator:
|
Thank you for confirming. |
Thank you! |
Closes #133
This PR fixes rebasing issues and failing iOS tests.