Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(osx): rename classes to fix plugin #152

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

NiklasMerz
Copy link
Member

Platforms affected

osx

Motivation and Context

The plugin is not working with the osx platform right now.

Description

This PR changes the name of the class to the same name as the JS classname and this makes this plugin work again.

Testing

Added plugin and ran tests on mac

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@NiklasMerz NiklasMerz requested review from brodycj and erisu February 5, 2022 18:42
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- but I don't have a mac to actually test these changes.

@NiklasMerz NiklasMerz merged commit 3b48f30 into apache:master Mar 31, 2022
@NiklasMerz NiklasMerz deleted the osx-classname branch March 31, 2022 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants