Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Noted android quirks on serial property #143

Merged
merged 2 commits into from
Sep 24, 2021

Conversation

breautek
Copy link
Contributor

@breautek breautek commented Sep 20, 2021

Platforms affected

Docs

Motivation and Context

Closes #111

Description

Added notes on the serial property for android and why it now returns UNKNOWN.

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@breautek breautek force-pushed the docs/android-uuid-quirk branch from 4f092ad to 4c55adf Compare September 20, 2021 16:56
@breautek breautek changed the title doc: Noted android quirks on uuid property doc: Noted android quirks on serial property Sep 20, 2021
@breautek
Copy link
Contributor Author

breautek commented Sep 20, 2021

Initial version of this PR had marked quirks on uuid property, but the actual property in question is actually serial. I was confused with the two properties. uuid property should still be usable. The serial property will always return UNKNOWN now, unless if the application have special privileged permissions, only available to phone manufacturers and/or carriers.

I've since changed and corrected this PR to reflect that.

README.md Outdated Show resolved Hide resolved
Co-authored-by: Niklas Merz <[email protected]>
@breautek breautek requested a review from NiklasMerz September 23, 2021 17:57
@breautek
Copy link
Contributor Author

Corrected the grammar error, thanks for the reviews!

@breautek breautek merged commit fb876b0 into apache:master Sep 24, 2021
@breautek breautek deleted the docs/android-uuid-quirk branch September 24, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In android 9.0 Device serial is unknown
3 participants