Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update typings #72

Merged
merged 1 commit into from
Mar 4, 2019
Merged

Conversation

timbru31
Copy link
Member

@timbru31 timbru31 commented Mar 2, 2019

this is part of apache/cordova#39

Platforms affected

n/a - development with TypeScript

Motivation and Context

updates typings as discussed in apache/cordova#39

Description

Updates type definition header, simplifies event types and correctly format the TSDoc.

Testing

Manual testing via development in VSCode.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@timbru31
Copy link
Member Author

timbru31 commented Mar 2, 2019

CI failure seems SauceLabs/Selenium related: UnknownError - An unknown server-side error occurred while processing the command. Selenium error: Invalid message: ERROR Internal Server Error

@janpio
Copy link
Member

janpio commented Mar 4, 2019

Restarted offending build.

@timbru31
Copy link
Member Author

timbru31 commented Mar 4, 2019

All green says my UI ;)

@janpio janpio merged commit 41d35b7 into apache:master Mar 4, 2019
@timbru31 timbru31 deleted the feat/update-typings branch March 4, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants