Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-12528 use fs instead of our own existsSync #524

Closed
wants to merge 1 commit into from

Conversation

purplecabbage
Copy link
Contributor

Platforms affected

Lib

What does this PR do?

Removes unneeded API

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@codecov-io
Copy link

codecov-io commented Mar 4, 2017

Codecov Report

Merging #524 into master will decrease coverage by -0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #524      +/-   ##
==========================================
- Coverage    81.9%   81.88%   -0.02%     
==========================================
  Files          68       68              
  Lines        5504     5498       -6     
  Branches     1090     1090              
==========================================
- Hits         4508     4502       -6     
  Misses        996      996
Impacted Files Coverage Δ
cordova-lib/src/cordova/util.js 97.2% <100%> (-0.08%)
cordova-lib/src/util/npm-helper.js 95.65% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0402b9...62d491f. Read the comment docs.

@stevengill
Copy link
Contributor

It was deprecated for a time but then got undeprecated. Great find! nodejs/node#1592

@asfgit asfgit closed this in d6f6a0e Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants