Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS: Fix running cordova build ios for emulators with Xcode 10.1 RELEASE #451

Merged
merged 2 commits into from
Nov 2, 2018

Conversation

kashban
Copy link
Contributor

@kashban kashban commented Nov 2, 2018

Successor of #428, ready for XCode 10.1 release.

Platforms affected

iOS

What does this PR do?

Fix scanning for available emulators to build / run against.

What testing has been done on this change?

Tests have been run on a Mac mini with Mac OS X Mojave 10.14 and Xcode 10.1.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

kashban and others added 2 commits October 10, 2018 18:05
From Xcode 10.1 on simctl List --json changed Format, so this has to be dealt with.
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from me

@codecov-io
Copy link

Codecov Report

Merging #451 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   74.29%   74.29%           
=======================================
  Files          12       12           
  Lines        1564     1564           
=======================================
  Hits         1162     1162           
  Misses        402      402

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14dd60d...b815161. Read the comment docs.

@dpogue dpogue merged commit 7a006db into apache:master Nov 2, 2018
@kashban
Copy link
Contributor Author

kashban commented Nov 2, 2018

Great! Looking forward to see this in the next release. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants