Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-14145 pin more added bundled dependencies in 4.5.x only #380

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Jul 23, 2018

Platforms affected

iOS

What does this PR do?

  • pin some more bundled dependencies to clear the red highlights in npm outdated --depth=0

What testing has been done on this change?

  • npm audit with [email protected] (latest version) shows 0 vulnerabilities
  • npm i && npm t passes on the following Node.js versions: deprecated Node.js 4 (npm 2.15.11), Node.js 6.14.3 (npm 3.10.10), Node.js 8.11.3 (npm 5.6.0), Node.js 10.7.0 (npm 6.1.0)
  • using cordova platform add brodybits/cordova-ios#cb-14145-pin-more-added-bundled-deps-in-patch-only to add platform to new Cordova project and test on iOS simulator using cordova run ios succeeds on the following Node.js versions:
    • deprecated Node.js 4 (npm 2.15.11)
    • Node.js 8 (npm 5.6.0)

CI testing:

  • verify that npm test stages and other tests pass on Travis CI
  • verify that installation, unit-tests, etc. pass on AppVeyor CI

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Needed to clear the red highlights in npm outdated --depth=0
@codecov-io
Copy link

codecov-io commented Jul 23, 2018

Codecov Report

Merging #380 into 4.5.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            4.5.x     #380   +/-   ##
=======================================
  Coverage   63.45%   63.45%           
=======================================
  Files          14       14           
  Lines        1691     1691           
  Branches      284      284           
=======================================
  Hits         1073     1073           
  Misses        618      618

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60be403...d5879ec. Read the comment docs.

@brodycj brodycj merged commit 3b662fc into apache:4.5.x Jul 23, 2018
@brodycj brodycj deleted the cb-14145-pin-more-added-bundled-deps-in-patch-only branch July 23, 2018 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants