feat!: Better Catalyst build support #1313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1313 +/- ##
==========================================
+ Coverage 80.22% 81.56% +1.34%
==========================================
Files 16 16
Lines 1871 1888 +17
==========================================
+ Hits 1501 1540 +39
+ Misses 370 348 -22 ☔ View full report in Codecov by Sentry. |
dpogue
changed the title
dpogue
changed the title
`cordova build ios --device --target=mac ...` Output is to `build/Debug-maccatalyst`
Xcode warns that only one can be enabled at a time, so we need to pick one, and Catalyst seems like the better option for a proper macOS app experience.
If neither `--device` nor `--emulator` are specified for the build command, it will check for a connected device and assume `--device` if one is found. However, it was also checking for the availability of the ios-deploy tool which is used to deploy to a connected device. If we're just building, we don't need to check for a deploy tool. The run command already has this check to ensure that ios-deploy is available before actually trying to deploy. Closes apacheGH-420. Closes apacheGH-677.
erisu
approved these changes
Aug 30, 2024
Looks like location access needs a capability to be turned on in the entitlements file for macOS/Catalyst. Once you do that, it works as expected. We can update the plugin to inject that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS, macOS
Motivation and Context
With the deprecation of cordova-osx and the availability of Catalyst to deploy iOS apps on macOS as their own app bundles, we should support targeting Catalyst builds.
Closes #420.
Closes #677.
Closes #1274.
Closes #1417.
Description
After the work in #1310 caused the build output folder to be named based on the platform, I realized this actually solved one of the remaining questions around where to put Catalyst output files... now they end up in
build/Debug-maccatalystorbuild/Release-maccatalystWe detect if we are building for Catalyst (as opposed to iOS Device vs iOS Simulator) by the
--target=macoption.Testing
cordova build ios --target=macworkscordova run ios --target=macworksChecklist