Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use async/await where applicable #89

Merged
merged 5 commits into from
Oct 16, 2020

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Preparation of a potential fix for apache/cordova-lib#859

Also: apache/cordova#175

Description

Use async/await where applicable

Testing

All automated tests still pass

@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #89 into master will increase coverage by 0.11%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   92.30%   92.42%   +0.11%     
==========================================
  Files           1        1              
  Lines          65       66       +1     
==========================================
+ Hits           60       61       +1     
  Misses          5        5              
Impacted Files Coverage Δ
index.js 92.42% <89.74%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dc1fe1...6511ecc. Read the comment docs.

raphinesse added a commit to raphinesse/cordova-fetch that referenced this pull request Oct 15, 2020
@raphinesse raphinesse mentioned this pull request Oct 15, 2020
6 tasks
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of these days I suppose I'll get used to this newfangled syntax, but I still think promises are more readable and make the async steps more explicit 😛

@raphinesse
Copy link
Contributor Author

raphinesse commented Oct 16, 2020

One of these days I suppose I'll get used to this newfangled syntax, but I still think promises are more readable and make the async steps more explicit

Promises are definitely more explicit and allow for very pretty code sometimes. And I also agree with async/await taking some getting used to. But once you are used to it, I think it really excels at making control flow involving async functions easier and more readable.

Anyway, thanks for the reviews 🙇

@raphinesse raphinesse merged commit 1d96eae into apache:master Oct 16, 2020
@raphinesse raphinesse deleted the async branch October 16, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants