-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use async/await where applicable #89
Conversation
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
==========================================
+ Coverage 92.30% 92.42% +0.11%
==========================================
Files 1 1
Lines 65 66 +1
==========================================
+ Hits 60 61 +1
Misses 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of these days I suppose I'll get used to this newfangled syntax, but I still think promises are more readable and make the async steps more explicit 😛
Promises are definitely more explicit and allow for very pretty code sometimes. And I also agree with async/await taking some getting used to. But once you are used to it, I think it really excels at making control flow involving async functions easier and more readable. Anyway, thanks for the reviews 🙇 |
Motivation and Context
Preparation of a potential fix for apache/cordova-lib#859
Also: apache/cordova#175
Description
Use async/await where applicable
Testing
All automated tests still pass