Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eslint setup #70

Merged
merged 1 commit into from
Nov 15, 2019
Merged

refactor: eslint setup #70

merged 1 commit into from
Nov 15, 2019

Conversation

erisu
Copy link
Member

@erisu erisu commented Oct 30, 2019 •
edited
Loading

Description

  • replace eslint dependencies with @cordova/eslint-config
  • update eslint config
  • eslint corrections

Testing

  • npm t

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 3.0.0 milestone Oct 30, 2019
@erisu erisu requested a review from raphinesse October 30, 2019 02:15
@erisu erisu force-pushed the v3-eslint branch 3 times, most recently from 68373da to ad71133 Compare November 1, 2019 02:22
@erisu erisu force-pushed the v3-eslint branch 2 times, most recently from 41f4b80 to edc9a72 Compare November 14, 2019 04:04
@erisu erisu changed the title chore: bump eslint dependencies refactor: eslint setup Nov 14, 2019
@erisu erisu force-pushed the v3-eslint branch 2 times, most recently from cd67303 to 3bc8bff Compare November 14, 2019 05:21
timbru31
timbru31 approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@erisu
refactor: eslint setup
44af17c 
* replace dependencies with @cordova/eslint-config
* update eslint config
* eslint corrections
@erisu erisu merged commit e5aba07 into apache:master Nov 15, 2019
@erisu erisu deleted the v3-eslint branch November 15, 2019 02:07
@raphinesse raphinesse mentioned this pull request Nov 27, 2019
Open
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breautek breautek breautek approved these changes

@raphinesse raphinesse raphinesse approved these changes

@timbru31 timbru31 timbru31 approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@erisu @timbru31 @raphinesse @breautek