Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Test using GitHub workflows for CI #95

Merged
merged 2 commits into from
Jan 5, 2020
Merged

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Oct 30, 2019

Platforms affected

macOS, Windows, Linux?

Motivation and Context

This potentially allows us to move away from TravisCI and Appveyor and consolidate all of our CI builds on a single system, which will hopefully be fast to run.

Description

Set up a GitHub Action that runs the tests automatically on Windows, macOS, and Linux (Ubuntu) when a PR is opened. Currently it's testing with node 10 and 12 (as per our plan to drop node 6 and 8).

Testing

Should get a bunch of green checkmarks from GitHub...

To Be Addressed

  • Reporting code coverage (there are some issues with codecov in GH actions needing a token. Coveralls looks like a workable alternative)
  • Ideally run eslint once as its own step, and report any concerns back inline in the file diff. GH actions isn't quite able to do this nicely yet, but it's on the way.

@dpogue dpogue changed the title WIP: Test using GitHub workflows for CI TEST: Test using GitHub workflows for CI Oct 30, 2019
@codecov-io
Copy link

codecov-io commented Oct 30, 2019

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files          20       20           
  Lines        1759     1759           
  Branches      361      361           
=======================================
  Hits         1551     1551           
  Misses        208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bd95b4...98ccfcc. Read the comment docs.

Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments, I think we might be able to start planning to merge this in.

It would be nice to also get some coverage service working but I am not entirely sure coveralls will work either.

Is the token something that must be kept as a secret or could it be added to a yaml file?

Additional Reference:
Since I mentioned cordova-eslint's usage in a few areas, here is a link to the file.
https://github.com/apache/cordova-eslint/blob/master/.github/workflows/nodejs.yml

cordova-common.js Outdated Show resolved Hide resolved
.github/workflows/pr_checks.yml Outdated Show resolved Hide resolved
.github/workflows/pr_checks.yml Outdated Show resolved Hide resolved
.github/workflows/pr_checks.yml Outdated Show resolved Hide resolved
.github/workflows/pr_checks.yml Outdated Show resolved Hide resolved
@erisu erisu added this to the 4.0.0 milestone Nov 8, 2019
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@erisu erisu merged commit 077b8cf into apache:master Jan 5, 2020
raphinesse added a commit to raphinesse/cordova-common that referenced this pull request Jan 6, 2020
raphinesse added a commit that referenced this pull request Jan 6, 2020
This regenerates `package-lock.json` from scratch as the file that was committed
in #95 did not match the dependencies from `package.json`.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.28%. Comparing base (291158c) to head (addb22c).
Report is 87 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #95   +/-   ##
=======================================
  Coverage   86.28%   86.28%           
=======================================
  Files          21       21           
  Lines        1560     1560           
=======================================
  Hits         1346     1346           
  Misses        214      214           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants