-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TEST: Test using GitHub workflows for CI #95
Conversation
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 88.17% 88.17%
=======================================
Files 20 20
Lines 1759 1759
Branches 361 361
=======================================
Hits 1551 1551
Misses 208 208 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comments, I think we might be able to start planning to merge this in.
It would be nice to also get some coverage service working but I am not entirely sure coveralls
will work either.
Is the token something that must be kept as a secret or could it be added to a yaml
file?
Additional Reference:
Since I mentioned cordova-eslint
's usage in a few areas, here is a link to the file.
https://github.com/apache/cordova-eslint/blob/master/.github/workflows/nodejs.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #95 +/- ##
=======================================
Coverage 86.28% 86.28%
=======================================
Files 21 21
Lines 1560 1560
=======================================
Hits 1346 1346
Misses 214 214 ☔ View full report in Codecov by Sentry. |
Platforms affected
macOS, Windows, Linux?
Motivation and Context
This potentially allows us to move away from TravisCI and Appveyor and consolidate all of our CI builds on a single system, which will hopefully be fast to run.
Description
Set up a GitHub Action that runs the tests automatically on Windows, macOS, and Linux (Ubuntu) when a PR is opened. Currently it's testing with node 10 and 12 (as per our plan to drop node 6 and 8).
Testing
Should get a bunch of green checkmarks from GitHub...
To Be Addressed