Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova events singleton object #60

Merged
merged 2 commits into from
Dec 20, 2018
Merged

Conversation

brodycj
Copy link
Contributor

@brodycj brodycj commented Dec 19, 2018

Using a real singleton object means that we would no longer have to follow the cordova-common singleton rule when publishing tools releases.

We may need to increase the minor version number if this change is included in cordova-common@3.

I would love to get this into the Cordova 9 release as discussed in apache/cordova#10, if possible.

Christopher J. Brody and others added 2 commits December 18, 2018 22:17
and replace var with const & let

Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Darryl Pogue <[email protected]>
Co-authored-by: Christopher J. Brody <[email protected]>
Co-authored-by: Darryl Pogue <[email protected]>
@brodycj brodycj requested review from dpogue and erisu December 19, 2018 03:35
@dpogue
Copy link
Member

dpogue commented Dec 19, 2018

Does EVENTS_RECEIVER also need to make sure there is only ever one instance?

@brodycj
Copy link
Contributor Author

brodycj commented Dec 19, 2018

Whichever CordovaEventEmitter instance is used should always use the same EVENTS_RECEIVER variable, from the same events.js module.

@brodycj brodycj merged commit 1bbc93d into apache:master Dec 20, 2018
@brodycj brodycj deleted the events-singleton branch December 20, 2018 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants