fix(ConfigFile): Normalize globbed file paths #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
force-pushed
the
config-file-normalize-glob-paths
branch
from
cff6ac3
to
d8e0ea4
Compare
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 88.04% 88.05% +0.01%
==========================================
Files 20 20
Lines 1171 1172 +1
==========================================
+ Hits 1031 1032 +1
Misses 140 140
Continue to review full report at Codecov.
|
erisu
approved these changes
Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glob always returns paths with forward slashes. This change ensures that a config file path obtained from a glob pattern will use the platform-specific path segment separator.
In preparation of merging #124.