refactor(PluginInfo): cleanup & simplify #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphinesse
force-pushed
the
pi-refactor
branch
from
3468aca
to
a5e4bff
Compare
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
+ Coverage 86.81% 86.81% +<.01%
==========================================
Files 20 20
Lines 1274 1244 -30
==========================================
- Hits 1106 1080 -26
+ Misses 168 164 -4
Continue to review full report at Codecov.
|
Co-authored-by: エリス <[email protected]>
raphinesse
force-pushed
the
pi-refactor
branch
from
a5e4bff
to
75b129b
Compare
erisu
approved these changes
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Minor cleanup & simplifications in various modules. Contains changes from #112 and ones that were triggered by me reviewing it.
Description
Simplification without functional changes. See commits for details.
Testing
npm t