Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use classes where applicable #119

Merged
merged 6 commits into from
Dec 15, 2019
Merged

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Dec 11, 2019

Motivation and Context

This applies some of the changes contained in #112. For more information see #113.

Diffs are best reviewed by commit and ignoring whitespace changes.

Description

Applied lebab --replace src --transform class to the code and made some adjustments before and after.

Testing

Passes our test suite

@raphinesse raphinesse added this to the 4.0.0 milestone Dec 15, 2019
@raphinesse raphinesse marked this pull request as ready for review December 15, 2019 20:52
@codecov-io
Copy link

Codecov Report

Merging #119 into master will decrease coverage by 0.55%.
The diff coverage is 89.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   87.39%   86.83%   -0.56%     
==========================================
  Files          20       20              
  Lines        1491     1405      -86     
==========================================
- Hits         1303     1220      -83     
+ Misses        188      185       -3
Impacted Files Coverage Δ
src/ActionStack.js 93.33% <100%> (-0.22%) ⬇️
src/ConfigChanges/ConfigKeeper.js 100% <100%> (ø) ⬆️
src/PluginInfo/PluginInfoProvider.js 82.14% <83.33%> (-1.73%) ⬇️
src/ConfigParser/ConfigParser.js 79.91% <83.87%> (-0.09%) ⬇️
src/PluginManager.js 88.63% <85.71%> (-3.04%) ⬇️
src/PlatformJson.js 79.22% <85.96%> (-3.2%) ⬇️
src/PluginInfo/PluginInfo.js 83.01% <86.36%> (-2.51%) ⬇️
src/ConfigChanges/ConfigFile.js 87.73% <88.46%> (-0.45%) ⬇️
src/ConfigChanges/ConfigChanges.js 94.64% <94.3%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 051cb9a...e3a7956. Read the comment docs.

@raphinesse raphinesse merged commit 485a82c into apache:master Dec 15, 2019
@raphinesse raphinesse deleted the classes branch December 15, 2019 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants