refactor(CordovaError)!: remove unused features

[raphinesse]

Motivation and Context

CordovaError implements a lot of features that we do not use anywhere in our code base. I also find these features of little use. This PR removes them.

The result is an Error subclass that does nothing except for stripping the Error: prefix from the usual result of Error.prototype.toString. Thus we should probably discuss if we want to remove CordovaError completely in the future or extend it with useful functionality.

One thing that would be actually useful is accepting a second parameter reason of type Error like in Java. That way it's easy to add information when catching an error and re-throwing it. Actually, the one place in our code that constructs a CordovaError with more than one argument tries to do exactly that. Unfortunately that's not how the constructor works currently.

Of course this change is a breaking one and non-Apache cordova-common consumers would be affected by it as well. However, I don't expect there to be many that use CordovaError.

Description

Removed features:

• support for an error context
• support for Cordova-specific error codes
• support for verbose toString

Testing

• Still passes unit tests
• Made sure we don't use the removed features anywhere

[codecov-io]

Codecov Report

Merging #117 into master will increase coverage by 0.65%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
+ Coverage   86.26%   86.91%   +0.65%     
==========================================
  Files          21       20       -1     
  Lines        1558     1529      -29     
==========================================
- Hits         1344     1329      -15     
+ Misses        214      200      -14

Impacted Files	Coverage Δ
cordova-common.js	0% <ø> (ø)	⬆️
src/CordovaError/CordovaError.js	100% <100%> (+13.04%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2021a39...0cf9175. Read the comment docs.

[brodycj]

👍

I hope we can look into adding the reason code soon, ideally in multiple places, as suggested in the description.