Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cordova config list command #421

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Fix cordova config list command #421

merged 1 commit into from
Apr 11, 2019

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Fixes #418 reported by @ltm

This is a patch-level change.

Testing

Manual testing & modified the existing unit test.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@raphinesse raphinesse added the bug label Apr 10, 2019
@raphinesse raphinesse requested review from erisu and dpogue April 10, 2019 21:29
dpogue
dpogue approved these changes Apr 10, 2019
View reviewed changes
Copy link
Member

@dpogue dpogue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

erisu
erisu approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raphinesse raphinesse merged commit 68d700f into apache:master Apr 11, 2019
@raphinesse raphinesse deleted the fix-config-list branch April 11, 2019 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erisu erisu erisu approved these changes

@dpogue dpogue dpogue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cordova config ls returns Error: ENOENT on clean install
3 participants
@raphinesse @dpogue @erisu