Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline browser_parser into Api #98

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raphinesse
Copy link
Contributor

Motivation and Context

Reduce (unused) code.

Description

  • Remove unused stuff from browser_parser
  • Inline remaining two methods from browser_parser into Api

This removes the property parser from Api instances. AFAIK this prop is not documented, so I'd consider it private. But if we would consider it public, this PR would be a major change.

Testing

I ran npm t

@codecov-commenter
Copy link

codecov-commenter commented Jun 3, 2020

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #98   +/-   ##
=======================================
  Coverage   93.54%   93.54%           
=======================================
  Files           2        2           
  Lines          31       31           
=======================================
  Hits           29       29           
  Misses          2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16271b4...d3d9328. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants