Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Improvements #152

Merged
merged 1 commit into from
Dec 29, 2020
Merged

Minor Improvements #152

merged 1 commit into from
Dec 29, 2020

Conversation

arturobernalg
Copy link
Member

  • Add final
  • Unused import
  • Unnecessary semicolon
  • Use Standard Charset object
  • Compare
  • Use primitive
  • Replace block comment to text plain
  • Redundant 'if' statement
  • Fix @ mail info

garydgregory
garydgregory requested changes Dec 21, 2020
View reviewed changes
pom.xml Outdated
@@ -65,49 +65,49 @@
<developer>
<name>James Strachan</name>
<id>jstrachan</id>
<email>jstrachan -at- apache.org</email>
<email>jstrachan@apache.org</email>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 don't fiddle with these please.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:-( revert change

...est/java/org/apache/commons/vfs2/provider/sftp/test/SftpProviderStreamProxyModeTestCase.java Outdated
@@ -32,7 +32,7 @@

import junit.framework.Test;

public class SftpProviderStreamProxyModeTestCase extends AbstractSftpProviderTestCase {
public class SftpProviderStreamProxyModeTestCase extends AbstractSftpProviderTestCase {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix formatting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

commons-vfs2/src/test/java/org/apache/commons/vfs2/provider/hdfs/test/HdfsFileProviderTest.java Outdated
@@ -117,7 +117,7 @@ public static void setUmask(final Configuration conf2) {
final BufferedReader bri = new BufferedReader(new InputStreamReader(p.getInputStream()));
final String line = bri.readLine();
p.waitFor();
final Short umask = Short.parseShort(line.trim(), 8);
final short umask = Short.parseShort(line.trim(), 8);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short.parseShort(line.trim(), 8) -> Short.parseShort(line.trim(), 8).shortValue() to make unboxing explicit

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't fallow. Revert only this change

@garydgregory garydgregory changed the title Minor Improvement: Minor Improvements Dec 27, 2020
garydgregory
garydgregory reviewed Dec 28, 2020
View reviewed changes
commons-vfs2/src/test/java/org/apache/commons/vfs2/RunTest.java Outdated
@@ -40,7 +40,7 @@ public static void main(final String[] args) throws Exception {
//props.setProperty("test.webdav.uri", "webdav://vfsusr:vfs%2f%25\\te:st@" + ip + "/vfstest");
props.setProperty("test.sftp.uri", "sftp://vfsusr:vfs%2f%25\\te:st@" + ip + "/vfstest");

final Test tests[] = new Test[] {
final Test tests[] = new Test[] {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix formatting.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix it

@arturobernalg
Minor Improvement:
8125273 
* Add final
* Unused import
* Unnecessary semicolon
* Use Standard Charset object
* Compare
* Use primitive
* Replace block comment to text plain
* Redundant 'if' statement
@garydgregory garydgregory merged commit bd1ed00 into apache:master Dec 29, 2020
asfgit pushed a commit that referenced this pull request Dec 29, 2020
@garydgregory
Minor Improvements #152.
92242bb
@arturobernalg arturobernalg deleted the feature/minor_improvement branch January 17, 2021 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garydgregory garydgregory garydgregory requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arturobernalg @garydgregory