-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor Improvements #152
Minor Improvements #152
Conversation
arturobernalg
commented
Dec 21, 2020
- Add final
- Unused import
- Unnecessary semicolon
- Use Standard Charset object
- Compare
- Use primitive
- Replace block comment to text plain
- Redundant 'if' statement
- Fix @ mail info
pom.xml
Outdated
@@ -65,49 +65,49 @@ | |||
<developer> | |||
<name>James Strachan</name> | |||
<id>jstrachan</id> | |||
<email>jstrachan -at- apache.org</email> | |||
<email>jstrachan@apache.org</email> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 don't fiddle with these please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-( revert change
@@ -32,7 +32,7 @@ | |||
|
|||
import junit.framework.Test; | |||
|
|||
public class SftpProviderStreamProxyModeTestCase extends AbstractSftpProviderTestCase { | |||
public class SftpProviderStreamProxyModeTestCase extends AbstractSftpProviderTestCase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -117,7 +117,7 @@ public static void setUmask(final Configuration conf2) { | |||
final BufferedReader bri = new BufferedReader(new InputStreamReader(p.getInputStream())); | |||
final String line = bri.readLine(); | |||
p.waitFor(); | |||
final Short umask = Short.parseShort(line.trim(), 8); | |||
final short umask = Short.parseShort(line.trim(), 8); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Short.parseShort(line.trim(), 8)
-> Short.parseShort(line.trim(), 8).shortValue()
to make unboxing explicit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't fallow. Revert only this change
@@ -40,7 +40,7 @@ public static void main(final String[] args) throws Exception { | |||
//props.setProperty("test.webdav.uri", "webdav://vfsusr:vfs%2f%25\\te:st@" + ip + "/vfstest"); | |||
props.setProperty("test.sftp.uri", "sftp://vfsusr:vfs%2f%25\\te:st@" + ip + "/vfstest"); | |||
|
|||
final Test tests[] = new Test[] { | |||
final Test tests[] = new Test[] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix formatting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix it
* Add final * Unused import * Unnecessary semicolon * Use Standard Charset object * Compare * Use primitive * Replace block comment to text plain * Redundant 'if' statement