Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit: fix .cs files with the trailing-whitespace hook #9794

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbampton
Copy link
Member

Description

This PR adds .cs files to the trailing-whitespace pre-commit hook.

This hook auto fixes and removes trailing whitespace when run locally on a users machine.

On the GitHub CI it just runs either pass or fail for now.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Ran locally: pre-commit run --all-files

How did you try to break this feature and the system with this change?

@jbampton
Copy link
Member Author

@blueorangutan package

@blueorangutan
Copy link

@jbampton a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.60%. Comparing base (554ea22) to head (60e3797).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9794      +/-   ##
============================================
- Coverage     16.60%   16.60%   -0.01%     
+ Complexity    12565    12564       -1     
============================================
  Files          5235     5235              
  Lines        460072   460072              
  Branches      56928    57689     +761     
============================================
- Hits          76408    76407       -1     
- Misses       375338   375339       +1     
  Partials       8326     8326              
Flag Coverage Δ
unittests 16.60% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11341

@jbampton jbampton marked this pull request as ready for review October 15, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants