fixes #2611

[nathanejohnson]

fix issue where kvm / ceph cannot create volumes #2611

Description

This hard codes the disk format to RAW in the case of RBD

Fixes: #2611

How Has This Been Tested?

This was tested in a centos 7 based lab on kvm with ceph primary storage.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

[rohityadavcloud]

Thanks @nathanejohnson I don't have a ceph setup to test this against, will help run regression tests.
@wido @GabrielBrascher can you help review and test this?
@blueorangutan package

[wido]

LGTM, I haven't looked at the history, but there was another if-statement which forced format for RBD to RAW already. That one probably is missing.

RBD is indeed always RAW, so yes, LGTM from me.

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2006

[rohityadavcloud]

@blueorangutan test

[rohityadavcloud]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2013

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[GabrielBrascher]

Code LGTM

[rohityadavcloud]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-2634)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52124 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2623-t2634-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 64 look OK, 3 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	Error	279.91	test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	Error	397.91	test_internal_lb.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	420.04	test_privategw_acl.py
test_04_rvpc_privategw_static_routes	Failure	470.36	test_privategw_acl.py
test_02_not_secured_vm_migration	Error	1.09	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	1.09	test_vm_life_cycle.py

[rohityadavcloud]

LGTM tests, merging based on code reviews and tests. Some failures are intermittent and not caused by this PR.