Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate methods to reset params #84

Merged
merged 1 commit into from
May 9, 2024

Conversation

vishesh92
Copy link
Member

@vishesh92 vishesh92 commented May 6, 2024

After merging PR #80 , optional params always needs to be set.
In case of the optional parameter of type UUID, the only option is to set the value to an empty string. This results in a request to ACS with the optional parameter in the request with an empty string. ACS throws an error because it can't find the associated id in the database.

Actual change is only in generate.go. Rest of the changes are in generated code.

@vishesh92 vishesh92 requested a review from shwstppr May 7, 2024 07:30
Copy link
Member

@rohityadavcloud rohityadavcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test it; the core changes are in generate.go

@rohityadavcloud rohityadavcloud marked this pull request as ready for review May 7, 2024 07:47
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. May need testing

@shwstppr shwstppr merged commit bc95c25 into apache:main May 9, 2024
1 check passed
@vishesh92 vishesh92 deleted the allow-param-reset branch May 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants