-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add api call createConsoleEndpoint #78
Conversation
add console endpoint to layout
change module name
fix websocket generation
add wrapper object
Preparations for pr
@weizhouapache @rohityadavcloud can you please review this PR? |
ping @shwstppr @vishesh92 can you review and advise on this PR, thanks. @sbrueseke has advised me privately that they need this for some use with the cloudstack packer plugin. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clgtm
No description provided.