Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Scheduled Snapshot to Recurring Snapshot #448

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abh1sar
Copy link
Contributor

@abh1sar abh1sar commented Oct 22, 2024

This is related to changes proposed in apache/cloudstack#9773

Recurring Snapshot is the name used at most places in code and documentation apart from 1-2 places where the word Scheduled Snapsthot is used.
For the sake of consistency, rename all to Recurring Snapshots.


📚 Documentation preview 📚: https://cloudstack-documentation--448.org.readthedocs.build/en/448/

@abh1sar abh1sar mentioned this pull request Oct 22, 2024
14 tasks
@@ -1011,7 +1011,7 @@ msgstr ""

#: ../../storage.rst:685
# bc81c587ad8b4032b27d61690390e258
msgid "With each snapshot schedule, users can also specify the number of scheduled snapshots to be retained. Older snapshots that exceed the retention limit are automatically deleted. This user-defined limit must be equal to or lower than the global limit set by the CloudStack administrator. See `“Globally Configured Limits” <usage.html#globally-configured-limits>`_. The limit applies only to those snapshots that are taken as part of an automatic recurring snapshot policy. Additional manual snapshots can be created and retained."
msgid "With each snapshot schedule, users can also specify the number of recurring snapshots to be retained. Older snapshots that exceed the retention limit are automatically deleted. This user-defined limit must be equal to or lower than the global limit set by the CloudStack administrator. See `“Globally Configured Limits” <usage.html#globally-configured-limits>`_. The limit applies only to those snapshots that are taken as part of an automatic recurring snapshot policy. Additional manual snapshots can be created and retained."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't it makes more sense to be like:

With each recurring snapshot, users can also specify the number of snapshots to be retained.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, how about "With each reccurring snapshot schedule, users can also specify the number of recurring snapshots to be retained."?

This is similar to the message shown in the Recurring Snapshots form.
Screenshot 2024-10-29 at 2 16 37 PM

@abh1sar
Copy link
Contributor Author

abh1sar commented Oct 29, 2024

@blueorangutan docbuild

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.

@blueorangutan
Copy link

QA-Doc build preview: https://qa.cloudstack.cloud/builds/docs-build/pr/448. (QA-JID 281)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants