Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve parsing descriptor file error when char data is unsigned #774

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Resolve parsing descriptor file error when char data is unsigned #774

merged 1 commit into from
Oct 14, 2024

Conversation

xuzhenbao
Copy link
Contributor

No description provided.

PengZheng
PengZheng approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@PengZheng PengZheng left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a bug we encountered when deploying RSA in production: for some toolchains, char is unsigned, then -1 will be 0xFF.

@xuzhenbao xuzhenbao merged commit 032438f into apache:master Oct 14, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PengZheng PengZheng PengZheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xuzhenbao @PengZheng