Add event admin remote provider based on mqtt #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te_event_admin # Conflicts: # bundles/event_admin/event_admin/gtest/src/CelixEventAdminTestSuite.cc # bundles/event_admin/event_admin/gtest/src/CelixEventAdminTestSuiteBaseClass.h # libs/utils/error_injector/celix_properties/CMakeLists.txt # libs/utils/error_injector/celix_properties/include/celix_properties_ei.h # libs/utils/error_injector/celix_properties/src/celix_properties_ei.cc
This reverts commit 97e1618.
|
@xuzhenbao Thanks for the PR. I am planning to review this, but this will require some time. |
|
pnoltes
reviewed
Nov 19, 2024
bundles/event_admin/event_admin/diagrams/remote_event_delivery_seq.puml
Outdated
Show resolved
Hide resolved
| return ENOMEM; | ||
| } | ||
| celix_properties_unset(remoteProps, CELIX_EVENT_REMOTE_ENABLE); | ||
| celix_status_t status = celix_properties_set(remoteProps, CELIX_EVENT_REMOTE_FRAMEWORK_UUID, ea->fwUUID); |
There was a problem hiding this comment.
👍 I like the design of an opt-in with CELIX_EVENT_REMOTE_ENABLE and the "this is a remote event" indication with CELIX_EVENT_REMOTE_FRAMEWORK_UUID.
pnoltes
requested changes
Dec 1, 2024
| celix_arrayList_removeAt(deliverer->syncEventQueue, 0); | ||
| } | ||
| celixThreadMutex_unlock(&deliverer->mutex); | ||
| if (entry != NULL) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.To deliver remote events, the
celix_event_remote_provider_service_tservice has been added , the relationship between event_admin and remote_provider is described in README.md.2.Add a remote provider bundle based on MQTT, refer to the README.md for the implementation.