Feature/509 remove deprecated version #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libs/framework/include_deprecated/module.h # libs/utils/include_deprecated/celix_utils_api.h
…deprecated-version
…deprecated-version # Conflicts: # bundles/remote_services/remote_service_admin_dfi/src/import_registration_dfi.c # libs/dfi/gtest/src/dyn_interface_tests.cpp # libs/dfi/gtest/src/dyn_message_tests.cpp
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 88.85% 88.94% +0.08%
==========================================
Files 216 216
Lines 24293 24200 -93
==========================================
- Hits 21585 21524 -61
+ Misses 2708 2676 -32 ☔ View full report in Codecov by Sentry. |
PengZheng
approved these changes
Feb 10, 2024
libs/framework/src/manifest_parser.c
Outdated
| @@ -37,7 +37,7 @@ struct manifestParser { | |||
| module_pt owner; | |||
| manifest_pt manifest; | |||
|
|
|||
| version_pt bundleVersion; | |||
| celix_version_t* bundleVersion; | |||
There was a problem hiding this comment.
nitpick: indentation mismatch when reviewed in CLion.
Also fix indentation in manifest_parser.c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
version.handversion_range.hheaders, their implementation and usage.This is part of #509.
Also refactors unit test so that the
celix_api is always used and introduces acelix_version_type.handcelix_version_range_type.h(which is part of #715)