Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/509 remove deprecated properties header #712

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

pnoltes
Copy link
Contributor

@pnoltes pnoltes commented Jan 1, 2024

This PR removes the deprecated properties API (api without a celix_ prefix) and refactors the usage of the deprecated properties API.

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ab7b7af) 88.33% compared to head (a48d5ae) 88.32%.

❗ Current head a48d5ae differs from pull request most recent head 11d9337. Consider uploading reports for the commit 11d9337 to get more accurate results

Files Patch % Lines
libs/framework/src/framework.c 25.00% 3 Missing ⚠️
libs/framework/src/service_registry.c 40.00% 3 Missing ⚠️
libs/framework/src/service_reference.c 0.00% 2 Missing ⚠️
libs/framework/src/service_registration.c 60.00% 2 Missing ⚠️
libs/framework/src/dm_component_impl.c 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
- Coverage   88.33%   88.32%   -0.02%     
==========================================
  Files         215      215              
  Lines       24500    24482      -18     
==========================================
- Hits        21643    21623      -20     
- Misses       2857     2859       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@PengZheng PengZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pnoltes pnoltes merged commit fc76439 into master Jan 4, 2024
28 checks passed
@pnoltes pnoltes deleted the feature/509-remove-deprecated-properties-header branch January 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants